Add --no-cache flag to deploy command#116
Open
emanuelefaja wants to merge 1 commit intoletsdiscodev:mainfrom
Open
Add --no-cache flag to deploy command#116emanuelefaja wants to merge 1 commit intoletsdiscodev:mainfrom
emanuelefaja wants to merge 1 commit intoletsdiscodev:mainfrom
Conversation
Passes `noCache: true` in the deployment request body when the user specifies `--no-cache`, allowing Docker builds without cache on the daemon side.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--no-cacheboolean flag to thedeploycommandnoCache: truein the POST request body to the daemon API when setUsage
Companion PR
Daemon side: letsdiscodev/disco-daemon#93
Files changed
src/commands/deploy.ts--no-cacheflag,noCacheto request interface and bodyTest plan
disco deploy --project <name>— works as before (nonoCachein body)disco deploy --project <name> --no-cache— sendsnoCache: truein request bodydisco deploy --help— shows--no-cacheflag in help output